]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
extensionSystem: Log an extension error if loading the stylesheet failed
authorJonas Dreßler <verdre@v0yd.nl>
Wed, 11 Sep 2019 12:55:04 +0000 (14:55 +0200)
committerFlorian Müllner <florian.muellner@gmail.com>
Thu, 12 Sep 2019 10:24:49 +0000 (10:24 +0000)
Instead of only logging a message that loading the extension stylesheet
failed and silently returning we should use `logExtensionError` for that
instead. This also sets the extension state to ERROR and makes sure we
don't try to enable it again.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/96

js/ui/extensionSystem.js

index 98ef13be97b8d5936755a2a7bbae8cc5bfb4477a..b1305187b76b528bd0773edd58d3753aa653d052 100644 (file)
@@ -121,7 +121,7 @@ var ExtensionManager = class {
             } catch (e) {
                 if (e.matches(Gio.IOErrorEnum, Gio.IOErrorEnum.NOT_FOUND))
                     continue; // not an error
-                log(`Failed to load stylesheet for extension ${uuid}: ${e.message}`);
+                this.logExtensionError(uuid, e);
                 return;
             }
         }